[PM-12512] Add Endpoint to allow users to request a new device otp #5146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ite a test for new method in UserService.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5146 +/- ##
==========================================
+ Coverage 42.96% 43.01% +0.05%
==========================================
Files 1444 1447 +3
Lines 66101 66157 +56
Branches 6057 6061 +4
==========================================
+ Hits 28397 28455 +58
+ Misses 36422 36420 -2
Partials 1282 1282 ☔ View full report in Codecov by Sentry. |
|
New Issues
Fixed Issues
|
rr-bw
requested review from
JaredSnider-Bitwarden
and removed request for
rr-bw
JaredSnider-Bitwarden
requested changes
Dec 13, 2024
JaredSnider-Bitwarden
previously approved these changes
Dec 14, 2024
JaredSnider-Bitwarden
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-12512
📔 Objective
When a user tries to log into a new device they are sent and OTP. If for any reason the OTP is invalid, or the user needs another OTP.
This PR adds an endpoint that allows the user to request another OTP in an unauthenticated state. Regardless of secret verification the endpoint will always return 200 to protect against account enumeration.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes